Bug 89409

Summary: Unmodified form control value is overwritten by another form control value with the same name after navigating and going back
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Severity: Normal CC: dglazkov, jonlee, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89412, 89539    
Bug Blocks: 23346    
Description Flags
Archive of layout-test-results from ec2-cr-linux-04
Patch none

Description Kent Tamura 2012-06-18 19:01:19 PDT

If a page has multiple form controls of which names are identical like the following,
  <input type=text name=name1 id=input1>
  <input type=text name=name1 id=input2>
and a user update the value of the second control, then go to another page and go back to the page again,

 The second input has the value which the user entered.

 The first input has the value which the user entered, and the second input has the initial value.
Comment 1 Kent Tamura 2012-06-19 22:10:55 PDT
Created attachment 148503 [details]
Comment 2 WebKit Review Bot 2012-06-19 22:14:51 PDT
Attachment 148503 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-06-19 22:43:40 PDT
Comment on attachment 148503 [details]

Attachment 148503 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13004116

New failing tests:
Comment 4 WebKit Review Bot 2012-06-19 22:43:43 PDT
Created attachment 148509 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Kent Tamura 2012-06-20 03:56:12 PDT
Created attachment 148534 [details]
Comment 6 Hajime Morrita 2012-06-20 18:21:44 PDT
Comment on attachment 148534 [details]

The state (de)serialization flow looks becoming a bit cryptic. 
My feeling is that it is because the state is stored as a string vector instead of string.
If we control the format, the code will become much cleaner.
Comment 7 WebKit Review Bot 2012-06-20 18:31:25 PDT
Comment on attachment 148534 [details]

Clearing flags on attachment: 148534

Committed r120895: <http://trac.webkit.org/changeset/120895>
Comment 8 WebKit Review Bot 2012-06-20 18:31:30 PDT
All reviewed patches have been landed.  Closing bug.