Bug 89387

Summary: Fix framebuffer-object-attachment.html failures
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: gman, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Zhenyao Mo
Reported 2012-06-18 15:05:17 PDT
A few bugs 1) in DEPTH_STENCIL_ATTACHMENT we put DEPTH_STENCIL 2) we should always do the re-attachments after removing an attachment buffer (either through framebufferRenderbuffer/framebufferTexture using a null buffer or deleteRenderbuffer/deleteTexture) due to the depth/stencil/depth_stencil conflicts 3) getParameter(DEPTH_BITS/STENCIL_BITS) bug: right now we assume it's always from drawing buffer
Attachments
Patch (11.00 KB, patch)
2012-06-18 15:15 PDT, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2012-06-18 15:15:32 PDT
Created attachment 148185 [details] Patch
Zhenyao Mo
Comment 2 2012-06-18 15:17:47 PDT
Test change will be added in a separate patch. This is because likely this patch needs to be merged back to chrome M21, and separating the tests change in another patch will reduce the possibility of conflicts.
Kenneth Russell
Comment 3 2012-06-18 15:24:14 PDT
Comment on attachment 148185 [details] Patch Looks good. I understand that this is being checked in separately from an updated version of the framebuffer-object-attachment.html layout test to make it easier to backport this fix; let's please update that test and its expectations ASAP though. r=me
Zhenyao Mo
Comment 4 2012-06-18 15:38:28 PDT
Committed r120636: <http://trac.webkit.org/changeset/120636>
Note You need to log in before you can comment on or make changes to this bug.