Bug 89376

Summary: [chromium] ContentLayerPainter should clear rect to be painted
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
remove more redundant clears
none
clear in CanvasLayerTextureUpdater enne: review+

James Robinson
Reported 2012-06-18 13:35:10 PDT
[chromium] ContentLayerPainter should clear rect to be painted
Attachments
Patch (3.51 KB, patch)
2012-06-18 13:40 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
remove more redundant clears (4.70 KB, patch)
2012-06-18 13:41 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
clear in CanvasLayerTextureUpdater (4.60 KB, patch)
2012-06-18 15:55 PDT, James Robinson 		enne: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-06-18 13:40:11 PDT
Created attachment 148164 [details] Patch
James Robinson
Comment 2 2012-06-18 13:41:07 PDT
Created attachment 148165 [details] remove more redundant clears
Stephen White
Comment 3 2012-06-18 13:59:28 PDT
Comment on attachment 148165 [details] remove more redundant clears The skia stuff looks ok, but I'll defer to enne or someone else more compositor-savvy for the rest.
Stephen White
Comment 4 2012-06-18 14:01:01 PDT
Oh, and could we get some test coverage for this?
Dana Jansens
Comment 5 2012-06-18 14:06:07 PDT
Comment on attachment 148165 [details] remove more redundant clears View in context: https://bugs.webkit.org/attachment.cgi?id=148165&action=review > Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp:-120 > - context.clearRect(contentRect); > - context.clip(contentRect); Is the implication that the canvas will now be cleared by the added code in ContentLayerPainter? Cuz I don't see how that can be, or is this being removed for a different reason?
Adrienne Walker
Comment 6 2012-06-18 14:49:45 PDT
Comment on attachment 148165 [details] remove more redundant clears View in context: https://bugs.webkit.org/attachment.cgi?id=148165&action=review > Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:69 > + SkPaint paint; > + paint.setAntiAlias(false); > + paint.setXfermodeMode(SkXfermode::kClear_Mode); > + canvas->drawRect(contentRect, paint); > + canvas->clipRect(contentRect); I think this should maybe go in CanvasLayerTextureUpdater so that the root and scrollbars get cleared properly, since both of those use different painters other than ContentLayerPainter.
James Robinson
Comment 7 2012-06-18 15:47:41 PDT
D'oh, will move it up.
James Robinson
Comment 8 2012-06-18 15:55:20 PDT
Created attachment 148193 [details] clear in CanvasLayerTextureUpdater
Adrienne Walker
Comment 9 2012-06-18 15:59:33 PDT
Comment on attachment 148193 [details] clear in CanvasLayerTextureUpdater R=me.
James Robinson
Comment 10 2012-06-18 16:16:24 PDT
Committed r120640: <http://trac.webkit.org/changeset/120640>
Note You need to log in before you can comment on or make changes to this bug.