Bug 89372 (VSPROPS_SAFESEH)

Summary: /SAFESEH should not be a common linker option
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2012-06-18 12:53:00 PDT
The file WebKitLibraries\win\tools\vsprops\common.vsprops has /SAFESEH as an additional linker option. This does not work with Visual Studio's x64 compiler. It seems to work without it, but I don't think this is a good solution. Is there a way to only use it for x86 solutions?
Attachments
Patch (9.97 KB, patch)
2012-06-21 09:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2012-06-21 09:36:32 PDT
Created attachment 148818 [details] Patch
WebKit Review Bot
Comment 2 2012-08-14 16:40:33 PDT
Comment on attachment 148818 [details] Patch Clearing flags on attachment: 148818 Committed r125622: <http://trac.webkit.org/changeset/125622>
WebKit Review Bot
Comment 3 2012-08-14 16:40:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.