Bug 89370 (CFBASE_MSVC_X64)
| Summary: | CFBase.h doesn't recognize MSVC x64 macros | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <alex.christensen> |
| Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Minor | CC: | bfulgham, paroga |
| Priority: | P3 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Alex Christensen
When compiling JavaScriptCore with MSVC for a 64-bit machine, CFBase.h gives the error "Do not know the endianess of this architecture". Not only is endianness spelled wrong, but this can be fixed by adding something like this before line 52:
#if defined(_MSC_VER) && defined(_M_X64)
#define __x86_64__ 1
#endif
Since this is not part of the repository (it's installed with update-webkit --wincairo), I cannot upload a patch.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patrick R. Gansterer
similar to https://bugs.webkit.org/show_bug.cgi?id=89374#c1
Brent Fulgham
This is actually something that needs to change in the WinCairo build requirements zip file. I'll correct it.
Brent Fulgham
I uploaded a new WinCairoRequirements bundle that addresses this issue. This isn't a WebKit bug, but rather a build environment problem.
Running "update-webkit --wincairo" should give you the new headers/binaries/link libraries.
Note that I do not provide 64-bit builds in this bundle at present.