Bug 89366

Summary:

FastMalloc.cpp needs to be reordered before padding bug can be fixed

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

bfulgham, darin, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

89608

Bug Blocks:

83344, 88344

Attachments:

Description	Flags
patch	none
Patch	none
Patch	none
Patch	none
Patch	rniwa: review+

Alex Christensen

Reported 2012-06-18 11:42:48 PDT

FastMalloc.cpp cannot be compiled by MSVC for x64 because of an error with a 0-length array. This can be fixed by using specialized templates, but the code needs to be reordered before doing so.

Attachments
patch (20.76 KB, patch) 2012-06-18 11:44 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (235.75 KB, patch) 2012-06-20 10:09 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (231.45 KB, patch) 2012-06-20 10:30 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (230.63 KB, patch) 2012-06-20 10:37 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (21.59 KB, patch) 2012-11-13 13:35 PST, Brent Fulgham	rniwa: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2012-06-18 11:44:57 PDT

Created attachment 148140 [details] patch patch

WebKit Review Bot

Comment 2 2012-06-18 11:47:09 PDT

Attachment 148140 [details] did not pass style-queue: Source/WTF/wtf/FastMalloc.cpp:1293: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/FastMalloc.cpp:970: Tab found; better to use spaces [whitespace/tab] [1] Source/WTF/wtf/FastMalloc.cpp:1114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1118: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1120: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1123: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1125: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1126: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1132: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1132: tc_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1159: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1160: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Source/WTF/wtf/FastMalloc.cpp:1161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1164: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1164: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1165: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1165: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1166: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Source/WTF/wtf/FastMalloc.cpp:1167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1174: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1177: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1180: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1185: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1186: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1191: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1192: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1193: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1195: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1197: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1198: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1198: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1199: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1199: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1201: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1203: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1204: locked_size_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1206: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1208: lock_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1210: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1211: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1211: Extra space between size_t and size_class_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1211: size_class_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1212: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1212: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1212: Extra space between Span and empty_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1212: empty_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1213: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1213: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1213: Extra space between Span and nonempty_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1213: nonempty_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1214: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1214: Extra space between size_t and counter_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1214: counter_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1216: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1219: tc_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1221: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1223: used_slots_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1224: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1224: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1226: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1227: cache_size_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1233: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1233: pad_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1260: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1279: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1290: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1291: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1293: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1293: kernel_supports_tls is incoFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1 rrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:1294: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1294: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1296: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1297: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1298: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1302: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1303: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1305: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1305: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/FastMalloc.cpp:1308: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/FastMalloc.cpp:1310: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1312: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WTF/wtf/FastMalloc.cpp:1313: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WTF/wtf/FastMalloc.cpp:1314: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1318: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1320: One line control clauses should not use braces. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1323: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1324: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1326: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1329: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1330: One space before end of line comments [whitespace/comments] [5] Total errors found: 147 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Rafael Brandao

Comment 3 2012-06-19 09:42:42 PDT

Comment on attachment 148140 [details] patch The code you've moved was not following webkit style guidelines (like arbitrary space identation). I believe it's ok to move and fix the style at the same time.

Ryosuke Niwa

Comment 4 2012-06-19 10:40:05 PDT

If you want your patch to be landed and you're not a committer yet, you should also ask for cq+.

WebKit Review Bot

Comment 5 2012-06-19 14:07:39 PDT

Comment on attachment 148140 [details] patch Rejecting attachment 148140 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 104 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 104. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12990096

Alex Christensen

Comment 6 2012-06-20 10:09:38 PDT

Created attachment 148591 [details] Patch

WebKit Review Bot

Comment 7 2012-06-20 10:13:12 PDT

Attachment 148591 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:574: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:588: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:4241: std::bad_alloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4392: __libc_malloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4393: __libc_free is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4394: __libc_realloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4395: __libc_calloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4396: __libc_cfree is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4397: __libc_memalign is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4398: __libc_valloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4399: __libc_pvalloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4400: __posix_memalign is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4404: __libc_malloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4405: __libc_free is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4406: __libc_realloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4407: __libc_calloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4408: __libc_cfree is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4409: __libc_memalign is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4410: __libc_valloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4411: __libc_pvalloc is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/FastMalloc.cpp:4412: __posix_memalign is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 21 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 8 2012-06-20 10:16:12 PDT

I just went through the whole file and fixed all the style errors except for a few. This one doesn't have any tabs, so it *should* commit ok...

Build Bot

Comment 9 2012-06-20 10:28:13 PDT

Comment on attachment 148591 [details] Patch Attachment 148591 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12997277

Alex Christensen

Comment 10 2012-06-20 10:30:22 PDT

Created attachment 148597 [details] Patch

Alex Christensen

Comment 11 2012-06-20 10:37:50 PDT

Created attachment 148599 [details] Patch

Ryosuke Niwa

Comment 12 2012-06-20 11:59:58 PDT

Too much change at once :( Please either just move the code or fix the style, don't do both in one patch.

Alex Christensen

Comment 13 2012-06-20 12:07:24 PDT

You review it then, Rafael. (In reply to comment #3) > (From update of attachment 148140 [details]) > The code you've moved was not following webkit style guidelines (like arbitrary space identation). I believe it's ok to move and fix the style at the same time.

Alex Christensen

Comment 14 2012-06-20 12:41:44 PDT

Either way, there is going to be a big patch. We need to move code that is not following webkit style, which means that it needs to be formatted into webkit style to be committed. This means changing variable names from variables with underscores, which must be changed everywhere the variable is used. This quickly makes it so I have to reformat the whole file, which I did. It was quite tedious, but it should be easy to check. Just use kdiff3 or something similar. Most of the changes are spaces or variable names. (In reply to comment #12) > Too much change at once :( Please either just move the code or fix the style, don't do both in one patch.

Ryosuke Niwa

Comment 15 2012-06-20 14:46:22 PDT

(In reply to comment #14) > Either way, there is going to be a big patch. We need to move code that is not following webkit style, which means that it needs to be formatted into webkit style to be committed. This means changing variable names from variables with underscores, which must be changed everywhere the variable is used. This quickly makes it so I have to reformat the whole file, which I did. > > It was quite tedious, but it should be easy to check. Just use kdiff3 or something similar. Most of the changes are spaces or variable names. A preferred approach for a big move like this is to fix all styles in one patch, move all code on the second patch, then fix the code on the third patch.

Alex Christensen

Comment 16 2012-06-20 15:58:06 PDT

Whatever. Bug 89608. All I did to get that is unmove the code. I think it's a bit excessive to have 3 patches, but whatever. > A preferred approach for a big move like this is to fix all styles in one patch, move all code on the second patch, then fix the code on the third patch.

Brent Fulgham

Comment 17 2012-11-13 13:35:30 PST

Created attachment 173971 [details] Patch

Brent Fulgham

Comment 18 2012-11-13 13:36:23 PST

I have revised the patch to work against current ToT. No code changes are present in this patch, aside from the reordering of some items in the file.

Brent Fulgham

Comment 19 2012-11-13 13:40:07 PST

I will land the patch once the EWS is finished processing.

Brent Fulgham

Comment 20 2012-11-13 13:50:43 PST

Committed r134479: <http://trac.webkit.org/changeset/134479>

Darin Adler

Comment 21 2012-11-13 17:38:40 PST

(In reply to comment #14) > We need to move code that is not following webkit style, which means that it needs to be formatted into webkit style to be committed. This is a false premise. We could simply inform the style checker that this file does not match the WebKit style. But it seems others on the project are OK with doing this large patch.

Brent Fulgham

Comment 22 2012-11-13 19:45:09 PST

We no longer need to commit the big reformatting patch. The only thing changed in this issue was the reordering of some of the file contents so that the new template declarations can be established for use in the rest of the file.

Note You need to log in before you can comment on or make changes to this bug.