Bug 89299 – Fix RebaselineTest python to work with webkit.org builders

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

In rebaseline.py:

    help_text = "Rebaseline a single test from a buildbot.  (Currently works only with build.chromium.org buildbots.)"

I presume this breaks rebaselining in garden-o-matic for non-chromium ports.

[Adam Barth]

Yeah.  I think this should be relatively easy to fix.

The way this works is that the front-end calls rebaselineall in gardeningserver.py via HTTP.  That process the HTTP request and calls "webkit-patch rebaseline-test".  If you get rebaseline-test working with the Apple ports, the rest of the machinery should fall into place.

rebaseline-test is in rebaseline.py.  My guess is that this command uses the accumulated results directory too, so you'll need to teach it how to find the most recent results directory, similar to what you did in the front-end:

    def _results_url(self, builder_name):
        # FIXME: Generalize this command to work with non-build.chromium.org builders.
        builder = self._tool.chromium_buildbot().builder_with_name(builder_name)
        return builder.accumulated_results_url()

Rather than getting the chromium_buildbot off the tool, you probably want something like the following:

self._tool.buildbot.builder_with_name(builder_name).latest_cached_build().results_url()

[Adam Barth]

Playing with the code you landed, it looks like we'll need to work in the "results" view a bit.  That view uses the accumulated results directory too, so we'll need to teach it to find the a results directory as well.  (Note: That's probably something for a separate bug since it's an issue with the front end.)

[Simon Fraser (smfr)]

Results panel: bug 89310
GOM parameter: bug 89309

[Simon Fraser (smfr)]

Didn't someone fix this?

[Ojan Vafai]

I did. :)