Bug 89284

Summary: Paint played and buffered ranges differently in Chrome video controls
Product: WebKit Reporter: Silvia Pfeiffer <silviapf>
Component: MediaAssignee: Silvia Pfeiffer <silviapf>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, cmarcelo, dglazkov, eric.carlson, eric, feature-media-reviews, macpherson, menard, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84672, 89696    
Attachments:
Description Flags
patch for review
none
Patch for cq
none
Archive of layout-test-results from ec2-cr-linux-03
none
some test updates - need to get the rest
none
Archive of layout-test-results from ec2-cr-linux-03
none
includes updated tests - also checked safari build and no new regressions none

Description Silvia Pfeiffer 2012-06-16 07:55:03 PDT
As part of the Chrome video controls visual update, the buffered range that is being played is painted in a lighter color left of the position thumb and lighter right of the position thumb.
Comment 1 Silvia Pfeiffer 2012-06-16 08:12:27 PDT
Created attachment 147967 [details]
patch for review
Comment 2 Silvia Pfeiffer 2012-06-18 18:21:15 PDT
Created attachment 148219 [details]
Patch for cq
Comment 3 WebKit Review Bot 2012-06-18 20:56:15 PDT
Comment on attachment 148219 [details]
Patch for cq

Attachment 148219 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12977483

New failing tests:
media/media-document-audio-repaint.html
fullscreen/full-screen-stacking-context.html
media/video-no-audio.html
media/controls-strict.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-repaint.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
http/tests/media/video-buffered-range-contains-currentTime.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-playing-and-pause.html
media/controls-layout-direction.html
media/controls-after-reload.html
Comment 4 WebKit Review Bot 2012-06-18 20:56:20 PDT
Created attachment 148236 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Silvia Pfeiffer 2012-06-20 08:46:19 PDT
Created attachment 148577 [details]
some test updates - need to get the rest
Comment 6 WebKit Review Bot 2012-06-20 13:18:54 PDT
Comment on attachment 148577 [details]
some test updates - need to get the rest

Attachment 148577 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13010019

New failing tests:
media/media-document-audio-repaint.html
fullscreen/full-screen-stacking-context.html
media/video-no-audio.html
media/controls-strict.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-repaint.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
http/tests/media/video-buffered-range-contains-currentTime.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-playing-and-pause.html
media/controls-layout-direction.html
media/controls-after-reload.html
Comment 7 WebKit Review Bot 2012-06-20 13:19:01 PDT
Created attachment 148641 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Silvia Pfeiffer 2012-06-20 22:51:59 PDT
Created attachment 148731 [details]
includes updated tests - also checked safari build and no new regressions
Comment 9 WebKit Review Bot 2012-06-21 10:32:32 PDT
Comment on attachment 148731 [details]
includes updated tests - also checked safari build and no new regressions

Clearing flags on attachment: 148731

Committed r120939: <http://trac.webkit.org/changeset/120939>
Comment 10 WebKit Review Bot 2012-06-21 10:32:38 PDT
All reviewed patches have been landed.  Closing bug.