Bug 89231

Summary: Remove vendor prefix from DOM MutationObservers
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, esprehn, gustavo, haraken, japhet, jochen, ojan, rakuco, syoichi, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89351, 90810, 109776    
Bug Blocks: 85161    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Disable by default on not-fully-supported platforms
none
Fix build
none
Patch
none
Patch slimmed down none

Adam Klein
Reported 2012-06-15 10:48:26 PDT
Unprefix DOM MutationObservers
Attachments
Patch (170.89 KB, patch)
2012-06-15 10:54 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch (170.92 KB, patch)
2012-06-15 11:16 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch (171.96 KB, patch)
2012-06-15 12:01 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Disable by default on not-fully-supported platforms (177.65 KB, patch)
2012-06-26 12:18 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Fix build (177.49 KB, patch)
2012-06-26 12:51 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch (177.18 KB, patch)
2012-06-28 17:51 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch slimmed down (56.52 KB, patch)
2012-07-09 15:21 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-06-15 10:54:16 PDT
Created attachment 147857 [details] Patch
Adam Klein
Comment 2 2012-06-15 11:16:44 PDT
Created attachment 147862 [details] Patch
Gustavo Noronha (kov)
Comment 3 2012-06-15 11:51:20 PDT
Comment on attachment 147862 [details] Patch Attachment 147862 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12968117
Adam Klein
Comment 4 2012-06-15 12:01:22 PDT
Created attachment 147869 [details] Patch
Gyuyoung Kim
Comment 5 2012-06-17 17:59:51 PDT
Comment on attachment 147869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147869&action=review > Source/WebKit/chromium/ChangeLog:3 > + Unprefix DOM MutationObservers Bug title is different. > Source/WebKit/efl/ChangeLog:3 > + Unprefix DOM MutationObservers ditto. > Source/WebKit/gtk/ChangeLog:3 > + Unprefix DOM MutationObservers ditto.
Adam Klein
Comment 6 2012-06-26 12:18:11 PDT
Created attachment 149584 [details] Disable by default on not-fully-supported platforms
Gustavo Noronha (kov)
Comment 7 2012-06-26 12:39:24 PDT
Comment on attachment 149584 [details] Disable by default on not-fully-supported platforms Attachment 149584 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13097540
Adam Klein
Comment 8 2012-06-26 12:51:44 PDT
Created attachment 149587 [details] Fix build
Adam Klein
Comment 9 2012-06-28 17:51:54 PDT
Created attachment 150052 [details] Patch
Adam Klein
Comment 10 2012-07-09 12:03:18 PDT
I've decided to split this change into smaller pieces; uploaded just the renaming of the WebCore class in bug 90810.
Adam Klein
Comment 11 2012-07-09 15:21:33 PDT
Created attachment 151331 [details] Patch slimmed down
Adam Klein
Comment 12 2013-01-08 14:42:05 PST
Comment on attachment 151331 [details] Patch slimmed down Removing review flag for now. This'll need a full rebasing anyway, and we don't want to do this until parser-mutations (bug 89351).
Elliott Sprehn
Comment 13 2013-02-13 17:55:47 PST
(In reply to comment #12) > (From update of attachment 151331 [details]) > Removing review flag for now. This'll need a full rebasing anyway, and we don't want to do this until parser-mutations (bug 89351). I missed this bug and created Bug 109776 , it also seems we can't land this patch now anyway since the mutation observer feature define doesn't exist anymore. Since Apple is shipping MutationObserver I think we should just unprefix everywhere. That they don't support end of task delivery seems like a bug in their implementation, not a reason to keep the prefix.
Adam Klein
Comment 14 2013-03-07 13:57:10 PST
esprehn did this in http://trac.webkit.org/changeset/143386
Note You need to log in before you can comment on or make changes to this bug.