Bug 109776 - Support both MutationObserver and WebKitMutationObserver
Summary: Support both MutationObserver and WebKitMutationObserver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks: 89231
  Show dependency tree / graph
 
Reported: 2013-02-13 17:26 PST by Elliott Sprehn
Modified: 2013-02-19 15:00 PST (History)
6 users (show)

See Also:

Attachments
Patch (42.95 KB, patch)
2013-02-13 17:57 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-02-13 17:26:17 PST 
Unprefix MutationObserver constructor
Comment 1 Elliott Sprehn 2013-02-13 17:57:15 PST 
Created attachment 188240 [details]
Patch
Comment 2 Ojan Vafai 2013-02-13 19:55:56 PST 
Comment on attachment 188240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review

> Source/WebCore/page/DOMWindow.idl:802
> +    attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this.

Should we add a test that the prefixed version still works?
Comment 3 Elliott Sprehn 2013-02-13 20:17:14 PST 
Comment on attachment 188240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review

>> Source/WebCore/page/DOMWindow.idl:802
>> +    attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this.
> 
> Should we add a test that the prefixed version still works?

I did, that's what the mutation-observer-prefix.html test is in the ChangeLog.
Comment 4 Ojan Vafai 2013-02-15 11:27:14 PST 
Comment on attachment 188240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188240&action=review

>>> Source/WebCore/page/DOMWindow.idl:802
>>> +    attribute MutationObserverConstructor WebKitMutationObserver; // FIXME: Add metrics to determine when we can remove this.
>> 
>> Should we add a test that the prefixed version still works?
> 
> I did, that's what the mutation-observer-prefix.html test is in the ChangeLog.

Ah. I missed that obviously. :)
Comment 5 WebKit Review Bot 2013-02-19 15:00:11 PST 
Comment on attachment 188240 [details]
Patch

Clearing flags on attachment: 188240

Committed r143386: <http://trac.webkit.org/changeset/143386>
Comment 6 WebKit Review Bot 2013-02-19 15:00:15 PST 
All reviewed patches have been landed.  Closing bug.