Bug 89176 – Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Use testRunner instead of layoutTestController in ietestcenter tests

[Ryosuke Niwa]

Created attachment 147745 [details]
Patch

[Ryosuke Niwa]

Created attachment 147746 [details]
Patch

[Kent Tamura]

Comment on attachment 147746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147746&action=review

> LayoutTests/ChangeLog:162
> +        * mhtml/check_domain.mht:
> +        * mhtml/frame_4.html_original:
> +        * mhtml/multi_frames.html_original:
> +        * mhtml/multi_frames_binary.mht:
> +        * mhtml/multi_frames_ie.mht:
> +        * mhtml/multi_frames_unmht.mht:
> +        * mhtml/page_with_css_and_js_ie.mht:
> +        * mhtml/page_with_css_and_js_unmht.mht:
> +        * mhtml/page_with_image.html_original:
> +        * mhtml/page_with_image_ie.mht:
> +        * mhtml/page_with_image_unmht.mht:
> +        * mhtml/simple_page.html_original:
> +        * mhtml/simple_page_ie.mht:
> +        * mhtml/simple_page_unmht.mht:

Do you need to update them?

> LayoutTests/ChangeLog:166
> +        * platform/chromium/media/resources/frame_size_change.webm:

Do you need to update webm!?

> LayoutTests/media/resources/foreignobject-media.svg:14
> -</svg>
>  \ No newline at end of file
> +</svg>

Looks unrelated.

> LayoutTests/media/track/track-webvtt-tc001-utf8.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc004-magic-header.html:77
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc005-header-comment.html:60
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc006-cue-identifiers.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc007-cue-no-id.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html:75
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc011-blank-lines.html:75
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc013-settings.html:85
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc014-alignment.html:70
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc015-positioning.html:70
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

[Kentaro Hara]

Comment on attachment 147746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147746&action=review

>> LayoutTests/media/resources/foreignobject-media.svg:14
>> +</svg>
> 
> Looks unrelated.

I think this is just automatically inserted by bugzilla. The patch would not include this change.

[Ryosuke Niwa]

(In reply to comment #4)
> (From update of attachment 147746 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147746&action=review
> 
> >> LayoutTests/media/resources/foreignobject-media.svg:14
> >> +</svg>
> > 
> > Looks unrelated.
> 
> I think this is just automatically inserted by bugzilla. The patch would not include this change.

This is a side effect of sed. It automatically inserts a new line at the end :(

[Ryosuke Niwa]

Created attachment 147750 [details]
Reverted the errornous changes

[Kent Tamura]

Comment on attachment 147750 [details]
Reverted the errornous changes

View in context: https://bugs.webkit.org/attachment.cgi?id=147750&action=review

> LayoutTests/inspector/audits/resources/audits-style1.css:4
> -}
>  \ No newline at end of file
> +}

This is unrelated.

> LayoutTests/media/remove-from-document-before-load.html:12
> -</body>
>  \ No newline at end of file
> +</body>

This part is unrelated to the bug, but it might be acceptable.

> LayoutTests/media/video-canvas.html-disabled:86
> -</html>
>  \ No newline at end of file
> +</html>

unrelated change

> LayoutTests/media/resources/foreignobject-media.svg:14
> -</svg>
>  \ No newline at end of file
> +</svg>

unrelated change

[Ryosuke Niwa]

Created attachment 147753 [details]
Reverted more unrelated changes

[Kent Tamura]

Comment on attachment 147753 [details]
Reverted more unrelated changes

probably ok

[Ryosuke Niwa]

Committed r120416: <http://trac.webkit.org/changeset/120416>