Bug 89141

Summary: [Chromium] Check the result of FontCache::getCachedFontPlatformData()
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-06-14 17:27:05 PDT
The function essentially returns the result of FontCache::createFontPlatformData(), which can be null. We should check the value before dereference. Detail: http://crbug.com/131004
Attachments
Patch (1.96 KB, patch)
2012-06-14 17:33 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-06-14 17:33:02 PDT
Created attachment 147688 [details] Patch
Kenichi Ishibashi
Comment 2 2012-06-14 17:36:22 PDT
Hi tony, kent-san, Could you take a look? I can't come up with a way to test this change because the problem depends on the settings of fontconfig and the problem won't occur with DRT.
Kent Tamura
Comment 3 2012-06-14 21:38:13 PDT
Comment on attachment 147688 [details] Patch Looks ok
Kenichi Ishibashi
Comment 4 2012-06-14 21:41:17 PDT
Comment on attachment 147688 [details] Patch Thanks!
WebKit Review Bot
Comment 5 2012-06-14 22:55:58 PDT
Comment on attachment 147688 [details] Patch Clearing flags on attachment: 147688 Committed r120402: <http://trac.webkit.org/changeset/120402>
WebKit Review Bot
Comment 6 2012-06-14 22:56:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.