Bug 89127

Summary: Fix framebuffer completeness test
Product: WebKit Reporter: Gregg Tavares <gman>
Component: WebGLAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Gregg Tavares
Reported 2012-06-14 14:54:46 PDT
Fix framebuffer completeness test
Attachments
Patch (10.48 KB, patch)
2012-06-14 14:55 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (16.36 KB, patch)
2012-06-14 15:43 PDT, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2012-06-14 14:55:22 PDT
Created attachment 147657 [details] Patch
Gregg Tavares
Comment 2 2012-06-14 15:43:11 PDT
Created attachment 147665 [details] Patch
Gregg Tavares
Comment 3 2012-06-14 15:44:08 PDT
The old code disallowed DEPTH_STENCIL attachments so I needed to update the expectations
Zhenyao Mo
Comment 4 2012-06-14 16:17:27 PDT
LGTM, thanks for fixing this.
Kenneth Russell
Comment 5 2012-06-14 17:44:10 PDT
Comment on attachment 147665 [details] Patch r=me based on Mo's review.
WebKit Review Bot
Comment 6 2012-06-14 22:54:09 PDT
Comment on attachment 147665 [details] Patch Clearing flags on attachment: 147665 Committed r120401: <http://trac.webkit.org/changeset/120401>
WebKit Review Bot
Comment 7 2012-06-14 22:54:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.