| Summary: | [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | enne, kbr, senorblanco | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2012-06-14 13:55:08 PDT
Created attachment 147651 [details]
Patch
Comment on attachment 147651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147651&action=review Thanks for fixing this. r=me > Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:179 > + // If we're rendering into a deferred device, we need to make a deep copy of the source pixels because Skia does not > + // retain a reference to the actual pixels otherwise. We check if we're drawing into a deferred device by seeing if the Nit: Technically, it's a deferred canvas, not a deferred device (SkPicture::beginRecording() returns an SkPictureRecord, which is a subclass of SkCanvas). Gotcha, I'll fix the comment before landing. Thanks! Committed r120501: <http://trac.webkit.org/changeset/120501> |