Bug 89079

Summary: new-run-webkit-websocketserver must handle TLS related arguments
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: Tools / TestsAssignee: Takashi Toyoshima <toyoshim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antonm, bashi, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Takashi Toyoshima
Reported 2012-06-14 01:57:50 PDT
Currently, new-run-webkit-websocketserver ignores TLS related arguments, -k and -c. Also we need to support --ca-certificate for client certificate authentication.
Attachments
Patch (4.01 KB, patch)
2012-06-14 02:04 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2012-06-14 02:04:35 PDT
Created attachment 147522 [details] Patch
Kenichi Ishibashi
Comment 2 2012-06-14 02:27:21 PDT
Comment on attachment 147522 [details] Patch LGTM. We don't need to modify NRWT?
Takashi Toyoshima
Comment 3 2012-06-14 03:12:45 PDT
Currently, I have no plan to use this feature from usual layout tests on NRWT. In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests. This is my major motivation to modify new-run-webkit-websocketserver now. Also this change will help some new client certificate layout tests in the future.
Kenichi Ishibashi
Comment 4 2012-06-14 05:47:13 PDT
(In reply to comment #3) > Currently, I have no plan to use this feature from usual layout tests on NRWT. > In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests. > This is my major motivation to modify new-run-webkit-websocketserver now. > Also this change will help some new client certificate layout tests in the future. I see. Thank you for explanation :)
Dirk Pranke
Comment 5 2012-06-14 10:26:42 PDT
Comment on attachment 147522 [details] Patch looks fine.
WebKit Review Bot
Comment 6 2012-06-14 11:06:58 PDT
Comment on attachment 147522 [details] Patch Clearing flags on attachment: 147522 Committed r120342: <http://trac.webkit.org/changeset/120342>
WebKit Review Bot
Comment 7 2012-06-14 11:07:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.