Bug 89020

Summary: [BlackBerry] Apply New Style and JS for Select Popup
Product: WebKit Reporter: Crystal Zhang <haizhang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89005    
Bug Blocks:    
Attachments:
Description Flags
patch none

Crystal Zhang
Reported 2012-06-13 10:44:11 PDT
Use new styled CSS files for select popup, also remove most JS functions to a separate JS file, only pass the parameters to JS, and use new python script for data generating, as the old one is too simple and problematic.
Attachments
patch (10.26 KB, patch)
2012-06-13 11:29 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2012-06-13 11:29:25 PDT
Created attachment 147371 [details] patch
Rob Buis
Comment 2 2012-06-13 12:14:29 PDT
Comment on attachment 147371 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=147371&action=review Looks good. > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:31 > +#include "PopupPicker.h" The name is slightly generic, I hope we do not have a name clash later....
WebKit Review Bot
Comment 3 2012-06-13 19:36:49 PDT
Comment on attachment 147371 [details] patch Clearing flags on attachment: 147371 Committed r120267: <http://trac.webkit.org/changeset/120267>
WebKit Review Bot
Comment 4 2012-06-13 19:36:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.