Bug 89015

Summary: [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: New BugsAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rakuco, robin.webkit, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-06-13 10:18:25 PDT
Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake.
Attachments
Patch (1.71 KB, patch)
2012-06-13 10:30 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2012-06-14 03:41 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-06-13 10:30:05 PDT
Created attachment 147356 [details] Patch
Robin Cao
Comment 2 2012-06-13 19:25:05 PDT
Thanks for the patch. I agree this file should move to UseJSC.cmake.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-06-13 19:35:46 PDT
Comment on attachment 147356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review > Source/WebCore/UseJSC.cmake:300 > +IF (ENABLE_MEDIA_STREAM) > + LIST (APPEND WebCore_SOURCES > + bindings/js/JSDeprecatedPeerConnectionCustom.cpp > + ) > +ENDIF () I think you can add this file to the list unconditionally, as it is already protected by an #ifdef.
Sudarsana Nagineni (babu)
Comment 4 2012-06-14 03:31:48 PDT
Comment on attachment 147356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review >> Source/WebCore/UseJSC.cmake:300 >> +ENDIF () > > I think you can add this file to the list unconditionally, as it is already protected by an #ifdef. Yes, it can be moved outside of ifdef guards. I just followed same as other modules included the .cpp files.
Sudarsana Nagineni (babu)
Comment 5 2012-06-14 03:41:58 PDT
Created attachment 147548 [details] Patch Fixed review comment #3.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-06-14 16:22:50 PDT
Looks fine to me.
WebKit Review Bot
Comment 7 2012-06-14 17:51:21 PDT
Comment on attachment 147548 [details] Patch Clearing flags on attachment: 147548 Committed r120382: <http://trac.webkit.org/changeset/120382>
WebKit Review Bot
Comment 8 2012-06-14 17:51:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.