Bug 89003

Summary: Web Inspector: Breakpoint's _uiLocationRemoved() method is never called.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-06-13 08:26:09 PDT
When _locationUpdated is called on breakpoint, _uiLocationRemoved should be called for primaryUILocation and oldUILocation. It doesn't now because map is used incorrectly.
Attachments
Patch (4.65 KB, patch)
2012-06-13 08:28 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-13 08:28:22 PDT
Created attachment 147322 [details] Patch
Pavel Feldman
Comment 2 2012-06-13 09:26:37 PDT
Comment on attachment 147322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147322&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:265 > + /** @type {Object.<string, WebInspector.UILocation>} */ swap the two
Vsevolod Vlasov
Comment 3 2012-06-13 10:33:10 PDT
Committed r120223: <http://trac.webkit.org/changeset/120223>
Note You need to log in before you can comment on or make changes to this bug.