Bug 88995

Summary: check-webkit-style needs to respect Qt API coding style
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Zoltan Horvath
Reported 2012-06-13 07:22:24 PDT
Add -whitespace/declaration exception to Qt API files. In the comment of: https://bugs.webkit.org/show_bug.cgi?id=88785#c4 I got a false positive alarm for Source/WebKit/qt/Api/qwebframe.cpp:1767: Declaration has space between type name and * in QImage *pix [whitespace/declaration] [3]
Attachments
proposed patch (1.49 KB, patch)
2012-06-13 07:24 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-06-13 07:24:07 PDT
Created attachment 147311 [details] proposed patch
Csaba Osztrogonác
Comment 2 2012-06-13 07:31:09 PDT
Comment on attachment 147311 [details] proposed patch rs=me
Zoltan Horvath
Comment 3 2012-06-13 08:15:54 PDT
Comment on attachment 147311 [details] proposed patch Clearing flags on attachment: 147311 Committed r120212: <http://trac.webkit.org/changeset/120212>
Zoltan Horvath
Comment 4 2012-06-13 08:16:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.