Bug 88995 - check-webkit-style needs to respect Qt API coding style
Summary: check-webkit-style needs to respect Qt API coding style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 07:22 PDT by Zoltan Horvath
Modified: 2012-06-13 08:16 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (1.49 KB, patch)
2012-06-13 07:24 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-06-13 07:22:24 PDT
Add -whitespace/declaration exception to Qt API files.
In the comment of: https://bugs.webkit.org/show_bug.cgi?id=88785#c4 I got a false positive alarm for Source/WebKit/qt/Api/qwebframe.cpp:1767:  Declaration has space between type name and * in QImage *pix  [whitespace/declaration] [3]
Comment 1 Zoltan Horvath 2012-06-13 07:24:07 PDT
Created attachment 147311 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2012-06-13 07:31:09 PDT
Comment on attachment 147311 [details]
proposed patch

rs=me
Comment 3 Zoltan Horvath 2012-06-13 08:15:54 PDT
Comment on attachment 147311 [details]
proposed patch

Clearing flags on attachment: 147311

Committed r120212: <http://trac.webkit.org/changeset/120212>
Comment 4 Zoltan Horvath 2012-06-13 08:16:04 PDT
All reviewed patches have been landed.  Closing bug.