Bug 88979

Summary: [Forms] Make RenderTextSingleLine usable from any element
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: NEW    
Severity: Normal CC: eric, gustavo, philn, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88980    
Bug Blocks:    
Attachments:
Description Flags
Patch 1 - WIP webkit-ews: commit-queue-

yosin
Reported 2012-06-13 03:06:21 PDT
This is part of implementing single line text edit control in shadow DOM.
Attachments
Patch 1 - WIP (37.28 KB, text/plain)
2012-06-18 03:11 PDT, yosin 		webkit-ews: commit-queue-
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-18 03:11:21 PDT
Created attachment 148079 [details] Patch 1 - WIP
yosin
Comment 2 2012-06-18 03:14:05 PDT
Comment on attachment 148079 [details] Patch 1 - WIP Could you review this patch as architecture review? Possible options are: 1. Proceed as is 2. Making SingleLineTextEditField in this patch 3. Or, another Thanks in advance.
Early Warning System Bot
Comment 3 2012-06-18 03:33:31 PDT
Comment on attachment 148079 [details] Patch 1 - WIP Attachment 148079 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12821025
Build Bot
Comment 4 2012-06-18 03:34:16 PDT
Comment on attachment 148079 [details] Patch 1 - WIP Attachment 148079 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12982039
Early Warning System Bot
Comment 5 2012-06-18 03:35:00 PDT
Comment on attachment 148079 [details] Patch 1 - WIP Attachment 148079 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12985019
yosin
Comment 6 2012-06-18 05:11:24 PDT
Comment on attachment 148079 [details] Patch 1 - WIP It seems making TextControlSingleLine shadow element derived from HTMLTextFormControlElement is better than set RenderTextControl free from HTMLTextFormControlElement.
yosin
Comment 7 2012-06-26 22:00:21 PDT
Postpone until we improve test coverage.
Note You need to log in before you can comment on or make changes to this bug.