Bug 88976

Summary:

REGRESSION(r120172): The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, ossy, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

88692

Attachments:

Description	Flags
ROLLOUT of r120172	none

Description WebKit Review Bot 2012-06-13 02:21:34 PDT

http://trac.webkit.org/changeset/120172 broke the build:
The patch causes compilation failures on Gtk, Qt and Apple Win bots (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

Comment 1 WebKit Review Bot 2012-06-13 02:22:22 PDT

Created attachment 147265 [details]
ROLLOUT of r120172

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Zan Dobersek 2012-06-13 02:26:40 PDT

Errors:
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/31631/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/Qt%20Linux%20ARMv7%20Release/builds/47182/steps/compile-webkit/logs/stdio
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/25151/steps/compile-webkit/logs/stdio

Comment 3 Zan Dobersek 2012-06-13 02:33:24 PDT

The GTK build error seemed to be just a temporary hick-up. CC-ing Ossy to get the Qt folk's attention about the errors.

Comment 4 Zan Dobersek 2012-06-13 02:38:48 PDT

Comment on attachment 147265 [details]
ROLLOUT of r120172

Clearing flags on attachment: 147265

Committed r120175: <http://trac.webkit.org/changeset/120175>

Comment 5 Zan Dobersek 2012-06-13 02:38:55 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Filip Pizlo 2012-06-13 11:33:47 PDT

The GTK+ failure seems to just be a problem on the GTK bots - the compiler was running out of memory.  Nothing I can do about that.  I will ignore that when rolling this back in.