Summary: | [Qt] REGRESSION(r120149): It made fast/workers/wrapper-map-gc.html crash | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Critical | CC: | ggaren, kadam, loki, oliver, ossy, zherczeg |
Priority: | P1 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 79668, 88840 |
Description
Csaba Osztrogonác
2012-06-12 23:13:54 PDT
And the following tests became flakey: (Fail with "FAIL: Timed out waiting for notifyDone to be called" and pass after rerunning tests) fast/workers/shared-worker-shared.html fast/workers/worker-script-error.html fast/workers/worker-terminate.html fast/workers/shared-worker-name.html fast/workers/worker-close-more.html fast/workers/worker-multi-startup.html fast/workers/shared-worker-script-error.html fast/workers/worker-lifecycle.html It's hard to reproduces this bug if you don't run all tests, because it is a GC bug ... But I managed to reproduce it on 32 bit Qt5 if I ran fast/workers tests. In this case fast/workers/worker-multi-startup.html crashes always. Any progression with fixing it? Or is this crash (serious GC bug!) absolutely acceptable? > Any progression with fixing it? Or is this crash (serious GC bug!) absolutely acceptable?
I don't have a Qt setup to debug this with. If there are Qt engineers who can debug GC issues, I can help. Otherwise, I'd suggest turning off parallel GC in the Qt port.
(In reply to comment #4) > > Any progression with fixing it? Or is this crash (serious GC bug!) absolutely acceptable? > > I don't have a Qt setup to debug this with. If there are Qt engineers who can debug GC issues, I can help. Otherwise, I'd suggest turning off parallel GC in the Qt port. Zoltán, as far as I know you have fixed GC related bugs previously. Could you pick it up, please? It seems it isn't Qt 5 and it isn't 32 bit specific bug, I managed to reproduce it with Qt 4.8 and on 64 bit too. But you can reproduce it simpler on 32 bit with any Qt version. If you run fast/workers tests, fast/workers/worker-multi-startup.html always crashes. It seems bash32 limits the number of threads to 512 for a given program. We should increse this. (In reply to comment #7) > It seems bash32 limits the number of threads to 512 for a given program. We should increse this. (In reply to comment #7) > It seems bash32 limits the number of threads to 512 for a given program. We should increse this. The problem isn't limited number of threads, but the 4G adress space. :-/ The default Stack size is 8M ( "ulimit -s == 8192" ) and 8M*512 = 4G, so we can't run more than 512 threads except we decrease the stack size. I'm going to check what happens if we decrease the stack size. It seems that decreasing stack size to 1M solves this problem. (and let WebKit to create max. 4096 threads) But I need a double check. (In reply to comment #9) > It seems that decreasing stack size to 1M solves this problem. (and let WebKit to create max. 4096 threads) But I need a double check. It solved the problem, we can close the bug. *** Bug 116855 has been marked as a duplicate of this bug. *** *** Bug 116854 has been marked as a duplicate of this bug. *** |