Bug 88931

Summary: some headers are included twice in WebCore
Product: WebKit Reporter: arno. <a.renevier>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, eric, feature-media-reviews, haraken, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch proposal
none
updated patch none

arno.
Reported 2012-06-12 15:34:58 PDT
In some WebCore, there are a few file with the same header included twice.
Attachments
patch proposal (6.59 KB, patch)
2012-06-12 15:37 PDT, arno. 		no flags
DetailsFormatted DiffDiff
updated patch (6.08 KB, patch)
2012-06-13 13:05 PDT, arno. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2012-06-12 15:37:34 PDT
Created attachment 147179 [details] patch proposal
Adam Barth
Comment 2 2012-06-12 16:01:26 PDT
Comment on attachment 147179 [details] patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review > Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:-38 > -#include "JSTestObj.h" This is a generated file. Please don't edit it. (Note: It should say that at the top.)
Rob Buis
Comment 3 2012-06-13 12:45:24 PDT
Comment on attachment 147179 [details] patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review Looks good, but you should try to remove the one so not to make the sorting worse. Also r- based on Adam's comment. > Source/WebCore/rendering/InlineFlowBox.cpp:-39 > -#include "RootInlineBox.h" I think you should remove the first occurrence of it, otherwise you violate (or keep violating) the alphabetic sorting rule.
arno.
Comment 4 2012-06-13 13:05:44 PDT
Created attachment 147396 [details] updated patch
WebKit Review Bot
Comment 5 2012-06-13 22:11:00 PDT
Comment on attachment 147396 [details] updated patch Clearing flags on attachment: 147396 Committed r120279: <http://trac.webkit.org/changeset/120279>
WebKit Review Bot
Comment 6 2012-06-13 22:11:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.