Bug 88923

Summary: REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, banga, ossy, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 79666, 86165, 95562    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-06-12 14:38:02 PDT
--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/loading/gmail-assert-on-load-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/loading/gmail-assert-on-load-actual.txt @@ -4,6 +4,7 @@ main frame - didFinishDocumentLoadForFrame frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame +frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed. Could you check it, please?
Attachments
Patch (4.11 KB, patch)
2012-06-13 12:14 PDT, Shrey Banga 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2012-06-13 12:37 PDT, Shrey Banga 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-12 14:57:08 PDT
I skipped it on Qt to paint the bot green. (r120126) Please unskip it with the proper fix.
Shrey Banga
Comment 2 2012-06-13 12:14:13 PDT
Created attachment 147384 [details] Patch
Csaba Osztrogonác
Comment 3 2012-06-13 12:16:36 PDT
Comment on attachment 147384 [details] Patch r=me, please unskip it on Qt too. Thanks.
Shrey Banga
Comment 4 2012-06-13 12:37:42 PDT
Created attachment 147392 [details] Patch
Csaba Osztrogonác
Comment 5 2012-06-13 12:40:09 PDT
Comment on attachment 147392 [details] Patch Thanks, r=me. But it seems svn-apply has problems with the patch.
Csaba Osztrogonác
Comment 6 2012-06-13 12:46:09 PDT
Landed manually - r120237
Shrey Banga
Comment 7 2012-06-13 13:10:29 PDT
(In reply to comment #6) > Landed manually - r120237 Thanks!
Note You need to log in before you can comment on or make changes to this bug.