Bug 88923

Summary:

REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, banga, ossy, tonyg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

79666, 86165, 95562

Attachments:

Description	Flags
Patch	none
Patch	none

Description Csaba Osztrogonác 2012-06-12 14:38:02 PDT

--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/loading/gmail-assert-on-load-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/loading/gmail-assert-on-load-actual.txt 
@@ -4,6 +4,7 @@
 main frame - didFinishDocumentLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
+frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
 This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.

Could you check it, please?

Comment 1 Csaba Osztrogonác 2012-06-12 14:57:08 PDT

I skipped it on Qt to paint the bot green. (r120126) Please unskip it with the proper fix.

Comment 2 Shrey Banga 2012-06-13 12:14:13 PDT

Created attachment 147384 [details]
Patch

Comment 3 Csaba Osztrogonác 2012-06-13 12:16:36 PDT

Comment on attachment 147384 [details]
Patch

r=me, please unskip it on Qt too. Thanks.

Comment 4 Shrey Banga 2012-06-13 12:37:42 PDT

Created attachment 147392 [details]
Patch

Comment 5 Csaba Osztrogonác 2012-06-13 12:40:09 PDT

Comment on attachment 147392 [details]
Patch

Thanks, r=me. But it seems svn-apply has problems with the patch.

Comment 6 Csaba Osztrogonác 2012-06-13 12:46:09 PDT

Landed manually - r120237

Comment 7 Shrey Banga 2012-06-13 13:10:29 PDT

(In reply to comment #6)
> Landed manually - r120237

Thanks!