Bug 88914
| Summary: | builders.py should autogenerate the list of builders from the buildbot json | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, dpranke, eric, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ojan Vafai
We shouldn't need to manually keep this list up to date. We should grab the list of builders from the buildbot json and filter out the non-testers. The flakiness dashboard does this and it requires almost no manual maintenance. See requestBuilderList in http://trac.webkit.org/browser/trunk/Tools/TestResultServer/static-dashboards/builders.js#L134.
The only tricky bit here is that builders.py has extra metadata that we'd have to infer from the buildername, specifically port_name and specifiers. Actually, now that I think about this more, is this the only place we map builder name to port name? Maybe we do need this list after all. :( Dirk or Adam, WDYT?
While we're at it we probably want to improve the naming so that it's clear that this list only contains testers.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
(In reply to comment #0)
> The only tricky bit here is that builders.py has extra metadata that we'd have to infer from the buildername, specifically port_name and specifiers. Actually, now that I think about this more, is this the only place we map builder name to port name? Maybe we do need this list after all. :( Dirk or Adam, WDYT?
>
Yeah, I dont know how you'd grab that data otherwise. I suppose you could then fetch individual results.json from the bots and extract the port name from that, but I'm not convinced it's worth it.
This list doesn't change very often; I think trying to automatically generate it sounds like it's more trouble than it is worth.
Ojan Vafai
Yeah, I just didn't think through this very clearly I think. Feel free to reopen if you think of a way to simplify maintaining this list.