Bug 88865

Summary: [Qt] Handle multiple held buttons in touch mocking.
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix holding released buttons
none
Patch for landing
none
Patch for landing none

Allan Sandfeld Jensen
Reported 2012-06-12 06:19:41 PDT
The touch mocking logic has a number of problems when multiple mouse buttons are held at the same time, in general the case is just not handled and results in undefined behavior.
Attachments
Patch (7.86 KB, patch)
2012-06-12 06:27 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Fix holding released buttons (8.00 KB, patch)
2012-06-12 07:23 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.20 KB, patch)
2012-06-13 05:36 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.21 KB, patch)
2012-06-13 05:38 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-06-12 06:27:12 PDT
Created attachment 147073 [details] Patch
Andras Becsi
Comment 2 2012-06-12 07:12:27 PDT
The patch breaks the removal of touch mock poins when simulating pinch-zoom, ie.: using ctrl. Both mock points remain on the screen if control is released earlier than one of the mouse buttons, and the first remains there if control is released after releasing one or both buttons.
Allan Sandfeld Jensen
Comment 3 2012-06-12 07:23:10 PDT
Created attachment 147079 [details] Fix holding released buttons
Andras Becsi
Comment 4 2012-06-12 07:51:10 PDT
Comment on attachment 147079 [details] Fix holding released buttons LGTM.
Kenneth Rohde Christiansen
Comment 5 2012-06-13 05:26:05 PDT
Comment on attachment 147079 [details] Fix holding released buttons View in context: https://bugs.webkit.org/attachment.cgi?id=147079&action=review > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:149 > + if (mouseEvent->buttons() > mouseEvent->button()) Migth deserve a comment > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:180 > + // A move can have resulted in multiple buttons, so we need check them out individually. I would remove 'out'
Allan Sandfeld Jensen
Comment 6 2012-06-13 05:36:26 PDT
Created attachment 147298 [details] Patch for landing
Allan Sandfeld Jensen
Comment 7 2012-06-13 05:38:06 PDT
Created attachment 147300 [details] Patch for landing Now with reviewer
WebKit Review Bot
Comment 8 2012-06-13 08:02:05 PDT
Comment on attachment 147300 [details] Patch for landing Clearing flags on attachment: 147300 Committed r120207: <http://trac.webkit.org/changeset/120207>
WebKit Review Bot
Comment 9 2012-06-13 08:02:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.