Bug 88863

Summary: [Qt][Win] Buildfix related to fromWinHBITMAP
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: jturcotte, kbalazs, ossy
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 88300    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-06-12 05:16:44 PDT
Patch is coming soon.
Attachments
Patch (3.46 KB, patch)
2012-06-12 05:38 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.52 KB, patch)
2012-06-12 06:03 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-12 05:38:53 PDT
Created attachment 147064 [details] Patch
Early Warning System Bot
Comment 2 2012-06-12 05:44:35 PDT
Comment on attachment 147064 [details] Patch Attachment 147064 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12936907
Csaba Osztrogonác
Comment 3 2012-06-12 06:03:13 PDT
Created attachment 147067 [details] Patch fixed patch
Jocelyn Turcotte
Comment 4 2012-06-12 06:20:27 PDT
Comment on attachment 147067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147067&action=review Just a nitpick. > Source/WebCore/platform/graphics/qt/ImageQt.cpp:59 > Q_GLOBAL_STATIC(WebGraphicHash, _graphics) > > +#if OS(WINDOWS) && HAVE(QT5) > +Q_GUI_EXPORT QPixmap qt_pixmapFromWinHBITMAP(HBITMAP, int hbitmapFormat = 0); > +#endif Ideally this would be moved up a bit after the includes and before the global static, as it's kind of part of the includes.
Csaba Osztrogonác
Comment 5 2012-06-12 06:32:06 PDT
(In reply to comment #4) > (From update of attachment 147067 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147067&action=review > > Just a nitpick. > > > Source/WebCore/platform/graphics/qt/ImageQt.cpp:59 > > Q_GLOBAL_STATIC(WebGraphicHash, _graphics) > > > > +#if OS(WINDOWS) && HAVE(QT5) > > +Q_GUI_EXPORT QPixmap qt_pixmapFromWinHBITMAP(HBITMAP, int hbitmapFormat = 0); > > +#endif > > Ideally this would be moved up a bit after the includes and before the global static, as it's kind of part of the includes. OK, fixed patch landed in http://trac.webkit.org/changeset/120065
Note You need to log in before you can comment on or make changes to this bug.