Bug 88860 – Refactor InputType::receiveDroppedFiles to take DragData

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Kinuko Yasuda]

This issue is splitted from bug 88293.

Refactor InputType::receiveDroppedFiles to take DragData and move the code extracting files from DragData into FileInputType.cpp, to make it easier to extract more data from DragData for <input type=file> (like bug 88293 for directory drag-and-drop).

[Kinuko Yasuda]

Created attachment 147058 [details]
Patch

[Kent Tamura]

Comment on attachment 147058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147058&action=review

> Source/WebCore/html/FileInputType.h:67
> -    virtual void receiveDroppedFiles(const Vector<String>&) OVERRIDE;
> +    virtual bool receiveDroppedFiles(const DragData*) OVERRIDE;

had better add a comment explaining what is the return value.

[Kent Tamura]

(In reply to comment #2)
> (From update of attachment 147058 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147058&action=review
> 
> > Source/WebCore/html/FileInputType.h:67
> > -    virtual void receiveDroppedFiles(const Vector<String>&) OVERRIDE;
> > +    virtual bool receiveDroppedFiles(const DragData*) OVERRIDE;
> 
> had better add a comment explaining what is the return value.

oh, not here.   we had better add it to HTMLInputElement.h and InputType.h.

[Kinuko Yasuda]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 147058 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=147058&action=review
> > 
> > > Source/WebCore/html/FileInputType.h:67
> > > -    virtual void receiveDroppedFiles(const Vector<String>&) OVERRIDE;
> > > +    virtual bool receiveDroppedFiles(const DragData*) OVERRIDE;
> > 
> > had better add a comment explaining what is the return value.
> 
> oh, not here.   we had better add it to HTMLInputElement.h and InputType.h.

Will do.  Thanks!

[Kinuko Yasuda]

Committed r120081: <http://trac.webkit.org/changeset/120081>