Bug 88853

Summary: [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70028    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Peter Beverloo
Reported 2012-06-12 04:13:32 PDT
[Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
Attachments
Patch (3.22 KB, patch)
2012-06-12 04:25 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (6.88 KB, patch)
2012-06-15 03:58 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (9.26 KB, patch)
2012-06-22 08:03 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-06-12 04:25:58 PDT
Created attachment 147052 [details] Patch
Steve Block
Comment 2 2012-06-13 11:36:31 PDT
Comment on attachment 147052 [details] Patch It looks like the same pattern also exists in the following files ... Source/WTF/WTF.gyp/WTF.gyp Source/WebCore/WebCore.gyp/WebCore.gyp Source/WebKit/chromium/WebKitUnitTests.gyp I imagine it needs fixing there too?
Peter Beverloo
Comment 3 2012-06-15 03:58:10 PDT
Created attachment 147788 [details] Patch
Peter Beverloo
Comment 4 2012-06-15 04:03:24 PDT
(In reply to comment #2) > (From update of attachment 147052 [details]) > It looks like the same pattern also exists in the following files ... > Source/WTF/WTF.gyp/WTF.gyp > Source/WebCore/WebCore.gyp/WebCore.gyp > Source/WebKit/chromium/WebKitUnitTests.gyp > > I imagine it needs fixing there too? Ah yes, sorry. Done. This can be landed after the following patch rolls into WebKit, I can keep an eye out and handle this as soon as that happens. https://chromiumcodereview.appspot.com/10546152/
Steve Block
Comment 5 2012-06-19 07:13:51 PDT
Comment on attachment 147788 [details] Patch Looks like you're still missing WebCore.gyp?
Steve Block
Comment 6 2012-06-22 07:42:19 PDT
It would be great to update this patch and land it soon!
Peter Beverloo
Comment 7 2012-06-22 08:03:10 PDT
Created attachment 149030 [details] Patch
Steve Block
Comment 8 2012-06-22 08:04:21 PDT
Comment on attachment 149030 [details] Patch thanks!
WebKit Review Bot
Comment 9 2012-06-22 09:20:51 PDT
Comment on attachment 149030 [details] Patch Clearing flags on attachment: 149030 Committed r121028: <http://trac.webkit.org/changeset/121028>
WebKit Review Bot
Comment 10 2012-06-22 09:20:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.