Bug 88851

Summary: Remove support for counterValueForElementById from chromium port
Product: WebKit Reporter: Kaustubh Atrawalkar <kaustubh.ra>
Component: Tools / TestsAssignee: Kaustubh Atrawalkar <kaustubh.ra>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, kaustubh.ra, morrita, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84406    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Kaustubh Atrawalkar
Reported 2012-06-12 03:58:51 PDT
This API has been moved to window.Internals Remove the supported APIs from webkit's chromium port. Reference - https://bugs.webkit.org/show_bug.cgi?id=84406
Attachments
Patch (3.24 KB, patch)
2012-06-14 02:45 PDT, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2012-06-14 20:21 PDT, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1 2012-06-14 02:45:58 PDT
Created attachment 147535 [details] Patch Removed the chromium port specific code for counterValueForElementById
WebKit Review Bot
Comment 2 2012-06-14 02:49:48 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-06-14 09:03:18 PDT
Comment on attachment 147535 [details] Patch Attachment 147535 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12950750
Adam Barth
Comment 4 2012-06-14 09:08:24 PDT
Comment on attachment 147535 [details] Patch The patch is fine, but it looks like you've got a compile problem to work through.
Adam Barth
Comment 5 2012-06-14 09:08:57 PDT
Looks like someone is using this feature: Source/WebKit/chromium/webkit/glue/webkit_glue.cc: In function 'bool webkit_glue::CounterValueForElementById(WebKit::WebFrame*, const std::string&, string16*)':
James Robinson
Comment 6 2012-06-14 09:58:08 PDT
That was removed in chromium r141631, so I suspect you just need to roll http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS forward past that revision
Kaustubh Atrawalkar
Comment 7 2012-06-14 19:27:54 PDT
Thanks Adam for the review. And yes, this I had logged bug with chromium and removed it from there in r141631. I saw the DEPS has been just updated yesterday past that r141631 (currently r141884) So i will just try to hit the patch again for cr-ews. and if passes will commit.
Kaustubh Atrawalkar
Comment 8 2012-06-14 20:21:06 PDT
Created attachment 147718 [details] Patch Another upload for patch for build check of cr-linux
Adam Barth
Comment 9 2012-06-14 20:46:36 PDT
Comment on attachment 147718 [details] Patch Let's see if it compiles!
WebKit Review Bot
Comment 10 2012-06-14 23:33:42 PDT
Comment on attachment 147718 [details] Patch Clearing flags on attachment: 147718 Committed r120408: <http://trac.webkit.org/changeset/120408>
WebKit Review Bot
Comment 11 2012-06-14 23:33:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.