Bug 88849

Summary:

[BlackBerry] Enable MEDIA_STREAM by default

Product:

WebKit

Reporter:

Robin Cao <robin.webkit>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

charles.wei, eric.carlson, feature-media-reviews, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
patch	none
revised patch	none
patch for landing	none

Robin Cao

Reported 2012-06-12 02:41:47 PDT

Enable MEDIA_STREAM by default in the BlackBerry port.

Attachments
patch (25.87 KB, patch) 2012-06-12 06:43 PDT, Robin Cao	no flags	Details Formatted Diff Diff
revised patch (25.88 KB, patch) 2012-06-12 18:14 PDT, Robin Cao	no flags	Details Formatted Diff Diff
patch for landing (25.86 KB, patch) 2012-06-12 19:59 PDT, Robin Cao	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Robin Cao

Comment 1 2012-06-12 06:43:00 PDT

Created attachment 147075 [details] patch

WebKit Review Bot

Comment 2 2012-06-12 06:46:53 PDT

Attachment 147075 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/CMakeLists.tx..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Robin Cao

Comment 3 2012-06-12 18:14:32 PDT

Created attachment 147205 [details] revised patch

Antonio Gomes

Comment 4 2012-06-12 18:26:07 PDT

Comment on attachment 147205 [details] revised patch It looks generally good, Robin. Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch.

Robin Cao

Comment 5 2012-06-12 18:42:12 PDT

(In reply to comment #4) > (From update of attachment 147205 [details]) > It looks generally good, Robin. > > Could you clarify the use of DeprecatedPeerConnectionHandler class. It does not seem to be used by the patch. Thanks for the reivew! DeprecatedPeerConnectionHandler is used in DeprecatedPeerConnection, see the contractor in Source/WebCore/Modules/mediastream/DeprecatedPeerConnection.cpp. We need this empty implementations to make it build.

Antonio Gomes

Comment 6 2012-06-12 19:41:39 PDT

Comment on attachment 147205 [details] revised patch View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29 > +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page) 'page' is unneeded. > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45 > +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request) ditto

Robin Cao

Comment 7 2012-06-12 19:45:57 PDT

(In reply to comment #6) > (From update of attachment 147205 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147205&action=review > > > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:29 > > +UserMediaClientImpl::UserMediaClientImpl(BlackBerry::WebKit::WebPage* page) > > 'page' is unneeded. > > > Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp:45 > > +void UserMediaClientImpl::cancelUserMediaRequest(UserMediaRequest* request) > > ditto Good catch, I will fix this before commit.

Robin Cao

Comment 8 2012-06-12 19:59:59 PDT

Created attachment 147221 [details] patch for landing

WebKit Review Bot

Comment 9 2012-06-13 05:29:07 PDT

Comment on attachment 147221 [details] patch for landing Clearing flags on attachment: 147221 Committed r120188: <http://trac.webkit.org/changeset/120188>

WebKit Review Bot

Comment 10 2012-06-13 05:29:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.