Bug 88827

Summary: [Chromium] Browser Plugin: Expose advanceFocus to WebKit API so that guests can advance focus of theirs embedders
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Fady Samuel
Reported 2012-06-11 18:04:14 PDT
[Chromium] Browser Plugin: Expose advanceFocus to WebKit API so that guests can advance focus of theirs embedders
Attachments
Patch (3.04 KB, patch)
2012-06-11 18:04 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2012-06-13 14:12 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2012-06-22 12:47 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2012-06-11 18:04:59 PDT
Created attachment 146983 [details] Patch
WebKit Review Bot
Comment 2 2012-06-11 18:08:19 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-06-11 18:30:19 PDT
Comment on attachment 146983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146983&action=review > Source/WebKit/chromium/public/WebView.h:196 > + // The browser plugin needs to be able to tell its embedder when the guest > + // is done tabbing through controls and wants its embedder to advance its > + // tab position. This information belongs in the ChangeLog. We use comments in these header to describe what the functions do, not why we added them originally.
Fady Samuel
Comment 4 2012-06-13 14:12:48 PDT
Created attachment 147409 [details] Patch
Fady Samuel
Comment 5 2012-06-13 14:13:21 PDT
Comment on attachment 146983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146983&action=review Hi Adam, Could you please take another look? Thanks. >> Source/WebKit/chromium/public/WebView.h:196 >> + // tab position. > > This information belongs in the ChangeLog. We use comments in these header to describe what the functions do, not why we added them originally. Done.
Darin Fisher (:fishd, Google)
Comment 6 2012-06-22 12:30:24 PDT
Comment on attachment 147409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147409&action=review > Source/WebKit/chromium/public/WebView.h:197 > nit: preserve two lines of whitespace before section comment
Fady Samuel
Comment 7 2012-06-22 12:47:09 PDT
Created attachment 149087 [details] Patch
WebKit Review Bot
Comment 8 2012-06-22 14:28:54 PDT
Comment on attachment 149087 [details] Patch Clearing flags on attachment: 149087 Committed r121057: <http://trac.webkit.org/changeset/121057>
WebKit Review Bot
Comment 9 2012-06-22 14:29:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.