Bug 88808

Summary:

[BlackBerry] Fix crash in InputHandler

Product:

WebKit

Reporter:

Crystal Zhang <haizhang>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	tonikitoo: review+
upated patch	tonikitoo: review+, tonikitoo: commit-queue-
updated patch	none
updated patch	none

Description Crystal Zhang 2012-06-11 14:25:53 PDT

m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().

Comment 1 Crystal Zhang 2012-06-11 15:11:01 PDT

Created attachment 146927 [details]
patch

Comment 2 Antonio Gomes 2012-06-11 15:37:58 PDT

chrystal is doing a change..

Comment 3 Crystal Zhang 2012-06-11 15:46:41 PDT

Created attachment 146938 [details]
upated patch

Comment 4 Antonio Gomes 2012-06-11 16:49:08 PDT

Comment on attachment 146938 [details]
upated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146938&action=review

> Source/WebKit/blackberry/ChangeLog:8
> +        m_page is destroyed before InputHandler, so should move the call to destroy popup to ~WebPagePrivate().

needs to update it :(

Comment 5 Crystal Zhang 2012-06-12 08:14:59 PDT

Created attachment 147089 [details]
updated patch

Comment 6 Crystal Zhang 2012-06-12 08:22:22 PDT

Created attachment 147090 [details]
updated patch

Comment 7 WebKit Review Bot 2012-06-12 10:29:16 PDT

Comment on attachment 147090 [details]
updated patch

Clearing flags on attachment: 147090

Committed r120091: <http://trac.webkit.org/changeset/120091>

Comment 8 WebKit Review Bot 2012-06-12 10:29:20 PDT

All reviewed patches have been landed.  Closing bug.