| Summary: | Speech JavaScript API: Make SpeechRecognitionError an Event | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||||
| Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, ojan, primiano, satish, tkent, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 80261 | ||||||||
| Attachments: |
|
||||||||
|
Description
Hans Wennborg
2012-06-11 08:07:48 PDT
Created attachment 146858 [details]
Patch
Comment on attachment 146858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review > Source/WebCore/Modules/speech/SpeechRecognitionError.h:52 > + static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); } Consider using emptyString() rather than "" if this is used only on the main thread. (It's ever so slightly faster.) > LayoutTests/ChangeLog:10 > + * fast/speech/scripted/speechrecognition-errors.html: Added. It looks like you forgot to "svn add" the -expected.txt file. This patch will cause the bots to turn red because this test is missing results. Comment on attachment 146858 [details] Patch Attachment 146858 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12942316 New failing tests: fast/events/constructors/speech-recognition-event-constructor.html Created attachment 146888 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
(In reply to comment #2) > (From update of attachment 146858 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146858&action=review Thanks for the review! > > Source/WebCore/Modules/speech/SpeechRecognitionError.h:52 > > + static PassRefPtr<SpeechRecognitionError> create() { return create(OTHER, ""); } > > Consider using emptyString() rather than "" if this is used only on the main thread. (It's ever so slightly faster.) Done. > > LayoutTests/ChangeLog:10 > > + * fast/speech/scripted/speechrecognition-errors.html: Added. > > It looks like you forgot to "svn add" the -expected.txt file. This patch will cause the bots to turn red because this test is missing results. Ouch! Thanks for spotting. Committed r120053: <http://trac.webkit.org/changeset/120053> |