Bug 88777

Summary: Add QML api for setting device width and height
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit Misc.Assignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, menard, webkit.review.bot, zalan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch hausmann: review+

Kenneth Rohde Christiansen
Reported 2012-06-11 06:20:48 PDT
SSIA. If a valid width/height is not set, we use the viewport dimensions for the viewport computation.
Attachments
Patch (11.81 KB, patch)
2012-06-11 06:29 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (11.83 KB, patch)
2012-06-11 06:35 PDT, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-06-11 06:29:52 PDT
Created attachment 146845 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-06-11 06:35:29 PDT
Created attachment 146846 [details] Patch
Simon Hausmann
Comment 3 2012-06-11 06:47:49 PDT
Comment on attachment 146846 [details] Patch r=me, but please add the missing device{Width/Height}Changed signal emissions in the setters when the value changed.
alan
Comment 4 2012-06-11 06:49:06 PDT
it looks okay to me, not sure whether QQuickWebViewExperimental should have this set-get pair, but I am not an API person.
alan
Comment 5 2012-06-11 06:49:36 PDT
ah, r+ already. goody then.
Kenneth Rohde Christiansen
Comment 6 2012-06-11 06:53:39 PDT
Landed in r119975
Note You need to log in before you can comment on or make changes to this bug.