Bug 88777

Summary:

Add QML api for setting device width and height

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit Misc.

Assignee:

Kenneth Rohde Christiansen <kenneth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, hausmann, menard, webkit.review.bot, zalan, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	hausmann: review+

Description Kenneth Rohde Christiansen 2012-06-11 06:20:48 PDT

SSIA.

If a valid width/height is not set, we use the viewport dimensions for the viewport computation.

Comment 1 Kenneth Rohde Christiansen 2012-06-11 06:29:52 PDT

Created attachment 146845 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2012-06-11 06:35:29 PDT

Created attachment 146846 [details]
Patch

Comment 3 Simon Hausmann 2012-06-11 06:47:49 PDT

Comment on attachment 146846 [details]
Patch

r=me, but please add the missing device{Width/Height}Changed signal emissions in the setters when the value changed.

Comment 4 zalan 2012-06-11 06:49:06 PDT

it looks okay to me, not sure whether QQuickWebViewExperimental should have this set-get pair, but I am not an API person.

Comment 5 zalan 2012-06-11 06:49:36 PDT

ah, r+ already. goody then.

Comment 6 Kenneth Rohde Christiansen 2012-06-11 06:53:39 PDT

Landed in r119975