| Summary: | Fix RequestAnimationFrameCallback.handleEvent return type in IDL. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||||
| Component: | WebCore JavaScript | Assignee: | Pavel Podivilov <podivilov> | ||||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||
| Severity: | Normal | CC: | abarth, cmarrin, dglazkov, dino, gustavo, haraken, jamesr, japhet, jochen, philn, pnormand, simon.fraser, sra, webkit-bug-importer, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pavel Podivilov
2012-06-11 06:15:10 PDT
Created attachment 146844 [details]
Patch
Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12925951 Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12941326 Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12939386 Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12947170 Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12946166 Comment on attachment 146844 [details] Patch Attachment 146844 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12940334 Comment on attachment 146844 [details]
Patch
Looks like you have some compilation errors to fix!
I'm not sure what the COMPILE_ASSERT problem is, but you do need to change the c++ bindings code type from bool to void to fix at least some of the errors.
Created attachment 147591 [details]
Patch
Created attachment 147593 [details]
Patch
Comment on attachment 147593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147593&action=review > Source/WebCore/ChangeLog:8 > + C++ callback's handleEvent implementation should always return bool, > + since its return type has nothing to do with IDL return type. why should C++'s handleEvent return bool? C++ GeneratedCallbackName::handleEvent returns negated result of WebCore::invokeCallback invocation for all callback types: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm#L3133. WebCore::invokeCallback returns true iff there was uncaught exception in JS callback: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp#L71 RequestAnimationFrameCallback::handleEvent result is ignored as well, see ScriptedAnimationController::serviceScriptedAnimations. But in any case, it seems unrelated to IDL return type. Comment on attachment 147593 [details]
Patch
Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
It's now: callback RequestAnimationFrameCallback = void (unrestricted double highResTime); Updated in https://trac.webkit.org/r208408 |