Summary: | [WebSocket] WebSocket object in Worker Context should fire error event when it fails connection. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Li Yin <li.yin> | ||||||
Component: | WebCore Misc. | Assignee: | Li Yin <li.yin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, levin+threading, tkent, toyoshim, webkit.review.bot, yutak | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 87336 | ||||||||
Attachments: |
|
Description
Li Yin
2012-06-10 20:14:56 PDT
Created attachment 146770 [details]
Patch
Comment on attachment 146770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review Looks okay except for one nitpick. > LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14 > +function testPassed(message) > +{ > + postMessage("Pass: " + message); > +} The output should look similar to postResult()'s. (In reply to comment #2) > (From update of attachment 146770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review > > Looks okay except for one nitpick. > > > LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14 > > +function testPassed(message) > > +{ > > + postMessage("Pass: " + message); > > +} > > The output should look similar to postResult()'s. OK, I will change the style, thanks for your review. (In reply to comment #2) > (From update of attachment 146770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146770&action=review > > Looks okay except for one nitpick. > > > LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:14 > > +function testPassed(message) > > +{ > > + postMessage("Pass: " + message); > > +} > > The output should look similar to postResult()'s. postResult()'s style looks strange. PASS PASS: ****, maybe one PASS is enough. Maybe style of http/tests/websocket/tests/hybi/close.html looks more nice :) Created attachment 146803 [details]
Patch
Hi Kent, Could you have a look? Thanks in advance. Thanks Kent for your review. Comment on attachment 146803 [details] Patch Clearing flags on attachment: 146803 Committed r120291: <http://trac.webkit.org/changeset/120291> All reviewed patches have been landed. Closing bug. |