Bug 88738

Summary: Some additional tweaks to keep TreeShared code simple/clean
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, haraken, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2012-06-10 10:47:55 PDT
Some additional tweaks to keep TreeShared code simple/clean
Attachments
Patch (1.82 KB, patch)
2012-06-10 10:50 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2012-06-10 10:50:09 PDT
Created attachment 146745 [details] Patch
Darin Adler
Comment 2 2012-06-10 10:50:44 PDT
Just a tiny tweak I missed when doing the last patch.
Kentaro Hara
Comment 3 2012-06-10 10:55:07 PDT
Comment on attachment 146745 [details] Patch Looks good to me. But I'd like to delegate the review to experts.
Adam Barth
Comment 4 2012-06-10 11:28:18 PDT
Comment on attachment 146745 [details] Patch Having a destructor be virtual or not based on NDEBUG sounds scary! That can lead to behavior differences between Release and Debug that are hard to track down.
Darin Adler
Comment 5 2012-06-10 11:30:44 PDT
(In reply to comment #4) > Having a destructor be virtual or not based on NDEBUG sounds scary! Yes, fixing that was my main motivation for this patch. I was in the shower and thinking about that virtual keyword there and came back to my computer to do this patch.
WebKit Review Bot
Comment 6 2012-06-10 12:19:37 PDT
Comment on attachment 146745 [details] Patch Clearing flags on attachment: 146745 Committed r119943: <http://trac.webkit.org/changeset/119943>
WebKit Review Bot
Comment 7 2012-06-10 12:19:42 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 8 2019-02-06 09:02:49 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.