Bug 88717

Summary: [EFL] Remove CMakeCache.txt before building
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, mrobinson, mxie, rwlbuis, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91387    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-06-09 11:47:49 PDT
The CMakeCache.txt file gets outdated when build DEFINES are changed (e.g. a feature is enabled). This leads to unexpected behavior when a flag such as "SHADOW_DOM" is added but is not taken into consideration because of the CMake cache. Newly unskipped tests will then fail on the bot because the functionality has not been enabled. This already happened several times. As a consequence, I'm proposing to edit the build script to remove the CMakeCache.txt before every build. This will effectively prevent this problem from happening again.
Attachments
Patch (1.50 KB, patch)
2012-06-09 11:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-06-09 11:50:59 PDT
Created attachment 146713 [details] Patch
Gyuyoung Kim
Comment 2 2012-06-10 03:57:36 PDT
I think CMakeCache.txt is still useful when we wanna build cmake project with other options. However, in this case, it looks we don't need to keep CMakeCache.txt because "build-webkit --efl" always uses same build directory. To my quick test, there is no big performance gain when we use CMakeCache.txt. So, I agree with this removal.
Dominik Röttsches (drott)
Comment 3 2012-06-11 00:46:57 PDT
LGTM, too. We need that.
WebKit Review Bot
Comment 4 2012-06-11 20:04:42 PDT
Comment on attachment 146713 [details] Patch Clearing flags on attachment: 146713 Committed r120032: <http://trac.webkit.org/changeset/120032>
WebKit Review Bot
Comment 5 2012-06-11 20:04:48 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 6 2012-06-26 06:49:18 PDT
*** Bug 87222 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.