Bug 88706

Summary: Web Inspector: Support user attributes in DOMNode
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 86630    
Description Flags
Patch pfeldman: review+

Description Alexander Pavlov (apavlov) 2012-06-09 04:25:21 PDT
This is needed for decorating DOM elements in the tree outline. It should be possible to determine if an element's children have a given user attribute defined, too.
Comment 1 Alexander Pavlov (apavlov) 2012-06-13 06:40:30 PDT
Created attachment 147307 [details]
Comment 2 Pavel Feldman 2012-06-13 07:27:22 PDT
Comment on attachment 147307 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=147307&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:707
> +    setUserAttribute: function(name, value)

setUserProperty ?

> Source/WebCore/inspector/front-end/DOMAgent.js:712
> +            var didHaveAttribute = this._userAttributes[name] !== null && this._userAttributes[name] !== undefined && this._userAttributes[name] !== false;

Lets clear on "null" only

> Source/WebCore/inspector/front-end/DOMAgent.js:718
> +        if (nowHaveAttribute)

This looks weird, I would extract "remove" method

> Source/WebCore/inspector/front-end/DOMAgent.js:731
> +        return this._descendantUserAttributeCounters && this._descendantUserAttributeCounters[name] ? this._descendantUserAttributeCounters[name] : 0;

I think this._descendantUserAttributeCounters can exist at all times.
Comment 3 Alexander Pavlov (apavlov) 2012-06-13 08:04:16 PDT
Committed r120208: <http://trac.webkit.org/changeset/120208>