Bug 88694

Summary: commit-queue flags in webkit-patch are confusing
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, commit-queue, dean_johnson, glenn, ojan, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2 none

Description Dirk Pranke 2012-06-08 18:23:21 PDT 
webkit-patch upload --request-commit 's help text says "Mark the patch as needing auto-commit after review". I'm not sure if this means cq? or cq+. Also, perhaps there should be a way to specify cq- ? (We default to None, which I think is correct). I'm not actually sure if there's a need for cq+, so maybe cq? is fine and we just need to update the help string?
Comment 1 Ojan Vafai 2012-06-08 19:34:38 PDT 
I think we just need to update the help string. Also, can we add a short version of request-commit? -cq? -c? --cq?
Comment 2 Adam Barth 2012-06-09 11:41:07 PDT 
"Request that the patch be added to the commit-queue once reviewed."

??
Comment 3 Dean Johnson 2015-07-23 16:58:53 PDT 
Created attachment 257409 [details]
Patch
Comment 4 Build Bot 2015-07-23 17:19:15 PDT 
Comment on attachment 257409 [details]
Patch

Attachment 257409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5322973896507392

New failing tests:
svg/W3C-SVG-1.1/animate-elem-02-t.svg
Comment 5 Build Bot 2015-07-23 17:19:18 PDT 
Created attachment 257412 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 WebKit Commit Bot 2015-07-24 01:05:12 PDT 
Comment on attachment 257409 [details]
Patch

Clearing flags on attachment: 257409

Committed r187332: <http://trac.webkit.org/changeset/187332>
Comment 7 WebKit Commit Bot 2015-07-24 01:05:16 PDT 
All reviewed patches have been landed.  Closing bug.