Bug 88668

Summary: [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
Product: WebKit Reporter: vollick
Component: WebKit Misc.Assignee: vollick
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

vollick
Reported 2012-06-08 10:36:40 PDT
It can currently happen that the single thread proxy's animation timer can fire before initialization starts. We should early out in this case.
Attachments
Patch (71.07 KB, patch)
2012-06-08 10:46 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Patch (71.05 KB, patch)
2012-06-08 12:06 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
vollick
Comment 1 2012-06-08 10:46:33 PDT
Created attachment 146603 [details] Patch This ended up being a 2 line change, but the testing required some more work. Rather than adding yet more tests to CCLayerTreeHostTest that don't belong there, I refactored the code required for running threaded tests into CCThreadedTest.h/cpp, added a CCSingleThreadProxyTest.cpp and moved the proxy- related tests into that file. This will allow us to more easily create new tests that require simulating the threaded environment.
vollick
Comment 2 2012-06-08 12:06:42 PDT
Created attachment 146623 [details] Patch Sorry for the spam. Making clang happy.
James Robinson
Comment 3 2012-06-08 12:51:32 PDT
Comment on attachment 146623 [details] Patch OMG Proxy tests yay! R=me.
WebKit Review Bot
Comment 4 2012-06-08 19:26:53 PDT
Comment on attachment 146623 [details] Patch Clearing flags on attachment: 146623 Committed r119886: <http://trac.webkit.org/changeset/119886>
WebKit Review Bot
Comment 5 2012-06-08 19:26:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.