Summary: | [chromium] WEBP image blue and red color channels reversed on Android | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||
Component: | New Bugs | Assignee: | noel gordon <noel.gordon> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, pascal.massimino, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | https://developers.google.com/speed/webp/gallery1 | ||||||
Attachments: |
|
Description
noel gordon
2012-06-07 21:25:39 PDT
Skia android is LITTLE_ENDIAN, but it stores pixels RGBA, see https://bugs.webkit.org/show_bug.cgi?id=75861#c6 Created attachment 146476 [details]
Patch
Tools/Scripts/new-run-webkit-tests --chromium --release fast/images/webp-image-decoding.html Works for me locally. Comment on attachment 146476 [details]
Patch
rubber stamped.
shouldn't the test be on "SK_A32_SHIFT" instead of "SK_B32_SHIFT" ? BGRA and RGBA -> the A shift is identical on a little-endian CPU, right? i'm fine with either ways, it's just that i saw the test being #ifndef SK_A32_SHIFT ... #endif at skia/include/core/SkPostConfig.h:165 your pick! Yes it's a little confusing, but but 78540 is your friend. Comment on attachment 146476 [details] Patch Clearing flags on attachment: 146476 Committed r119807: <http://trac.webkit.org/changeset/119807> All reviewed patches have been landed. Closing bug. Fine with me, if just for the (important) sake of coherency. Thanks for fixing this Noel! No worries. |