Bug 88613

Summary:

[chromium] WEBP image blue and red color channels reversed on Android

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

New Bugs

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, pascal.massimino, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

https://developers.google.com/speed/webp/gallery1

Attachments:

Description	Flags
Patch	none

noel gordon

Reported 2012-06-07 21:25:39 PDT

The JPEG images (on the left) on this URL, and the WEBP images (right), should look identical. On Chrome Android, the red and blue channels are reversed.

Attachments
Patch (1.63 KB, patch) 2012-06-07 22:06 PDT, noel gordon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2012-06-07 21:30:46 PDT

Skia android is LITTLE_ENDIAN, but it stores pixels RGBA, see https://bugs.webkit.org/show_bug.cgi?id=75861#c6

noel gordon

Comment 2 2012-06-07 22:06:19 PDT

Created attachment 146476 [details] Patch

noel gordon

Comment 3 2012-06-07 22:18:21 PDT

http://b/6311532

noel gordon

Comment 4 2012-06-07 22:31:52 PDT

Tools/Scripts/new-run-webkit-tests --chromium --release fast/images/webp-image-decoding.html Works for me locally.

Kent Tamura

Comment 5 2012-06-07 22:35:16 PDT

Comment on attachment 146476 [details] Patch rubber stamped.

Pascal Massimino

Comment 6 2012-06-07 23:23:54 PDT

shouldn't the test be on "SK_A32_SHIFT" instead of "SK_B32_SHIFT" ?

noel gordon

Comment 7 2012-06-07 23:29:41 PDT

BGRA and RGBA -> the A shift is identical on a little-endian CPU, right?

noel gordon

Comment 8 2012-06-07 23:43:56 PDT

Or for example, see bug 78540

Pascal Massimino

Comment 9 2012-06-08 00:17:50 PDT

i'm fine with either ways, it's just that i saw the test being #ifndef SK_A32_SHIFT ... #endif at skia/include/core/SkPostConfig.h:165 your pick!

noel gordon

Comment 10 2012-06-08 00:40:53 PDT

Yes it's a little confusing, but but 78540 is your friend.

WebKit Review Bot

Comment 11 2012-06-08 00:42:58 PDT

Comment on attachment 146476 [details] Patch Clearing flags on attachment: 146476 Committed r119807: <http://trac.webkit.org/changeset/119807>

WebKit Review Bot

Comment 12 2012-06-08 00:43:03 PDT

All reviewed patches have been landed. Closing bug.

Pascal Massimino

Comment 13 2012-06-08 00:46:30 PDT

Fine with me, if just for the (important) sake of coherency. Thanks for fixing this Noel!

noel gordon

Comment 14 2012-06-08 01:50:24 PDT

No worries.

Note You need to log in before you can comment on or make changes to this bug.