Bug 88594

Summary: DFG should inline prototype chain accesses, and do the right things if the specific function optimization is available
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
barraclough: review+
patch with Gavin's suggestions none

Filip Pizlo
Reported 2012-06-07 16:51:37 PDT
Patch forthcoming.
Attachments
the patch (22.37 KB, patch)
2012-06-07 16:54 PDT, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
patch with Gavin's suggestions (22.41 KB, patch)
2012-06-07 17:08 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-07 16:54:15 PDT
Created attachment 146419 [details] the patch
WebKit Review Bot
Comment 2 2012-06-07 16:58:14 PDT
Attachment 146419 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/GetByIdStatus.h:41: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/bytecode/GetByIdStatus.h:84: The parameter name "structure" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2012-06-07 17:04:38 PDT
Comment on attachment 146419 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=146419&action=review > Source/JavaScriptCore/bytecode/GetByIdStatus.cpp:67 > + UNUSED_PARAM(structure); Oh yes they are!
Filip Pizlo
Comment 4 2012-06-07 17:08:08 PDT
Created attachment 146423 [details] patch with Gavin's suggestions Putting up for EWS while I test it more.
WebKit Review Bot
Comment 5 2012-06-07 17:09:59 PDT
Attachment 146423 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/GetByIdStatus.h:41: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2012-06-07 18:31:55 PDT
Landed with some additional fixes in http://trac.webkit.org/changeset/119779
Alexey Proskuryakov
Comment 7 2012-06-11 14:12:56 PDT
This caused bug 88783.
Note You need to log in before you can comment on or make changes to this bug.