Bug 88576

Summary: [BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
Product: WebKit Reporter: Crystal Zhang <haizhang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rwlbuis: review-
updated patch none

Crystal Zhang
Reported 2012-06-07 14:26:35 PDT
When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use this to load popup, no need to create our own one. The old code is based on an old solution which has been abandoned.
Attachments
patch (9.04 KB, patch)
2012-06-07 14:40 PDT, Crystal Zhang 		rwlbuis: review-
DetailsFormatted DiffDiff
updated patch (9.41 KB, patch)
2012-06-07 15:10 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2012-06-07 14:40:12 PDT
Created attachment 146392 [details] patch
Rob Buis
Comment 2 2012-06-07 14:50:47 PDT
Comment on attachment 146392 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=146392&action=review Found one tiny cleanup possibility. Crystal will have a look whether more changes are needed. > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:-312 > - webPopup->closeWebPage(); You can remove the { and } now.
Crystal Zhang
Comment 3 2012-06-07 15:10:04 PDT
Created attachment 146397 [details] updated patch
Rob Buis
Comment 4 2012-06-07 15:19:04 PDT
Comment on attachment 146397 [details] updated patch LGTM.
WebKit Review Bot
Comment 5 2012-06-07 17:00:23 PDT
Comment on attachment 146397 [details] updated patch Clearing flags on attachment: 146397 Committed r119774: <http://trac.webkit.org/changeset/119774>
WebKit Review Bot
Comment 6 2012-06-07 17:00:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.