Bug 88573

Summary: Fix recent null pointer error regression in the flakiness dashboard
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+

Ojan Vafai
Reported 2012-06-07 13:43:27 PDT
Fix recent null pointer error regression in the flakiness dashboard
Attachments
Patch (3.68 KB, patch)
2012-06-07 13:43 PDT, Ojan Vafai 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-06-07 13:43:57 PDT
Created attachment 146377 [details] Patch
Dirk Pranke
Comment 2 2012-06-07 13:49:56 PDT
Comment on attachment 146377 [details] Patch looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python?
Ojan Vafai
Comment 3 2012-06-07 13:58:51 PDT
(In reply to comment #2) > (From update of attachment 146377 [details]) > looks fine to me, but my JS-fu isn't terribly strong. Is it possible for something in the test to throw an exception that would cause doXHR not to be reassigned back to oldDoXHR? i.e. does that need to wrapped in a try/finally like you would in python? yes. good idea.
Ojan Vafai
Comment 4 2012-06-07 14:32:43 PDT
Committed r119754: <http://trac.webkit.org/changeset/119754>
Note You need to log in before you can comment on or make changes to this bug.