Bug 88563

Summary: [BlackBerry] Show correct fullscreen button image (media controls)
Product: WebKit Reporter: Max Feil <mfeil>
Component: WebKit BlackBerryAssignee: Max Feil <mfeil>
Status: CLOSED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Max Feil
Reported 2012-06-07 11:39:35 PDT
The "enter" fullscreen button image is currently being rendered all the time. This needs to be changed so that the "exit" fullscreen button image is rendered when the video is fullscreen. PR159306
Attachments
Patch (2.56 KB, patch)
2012-06-07 11:46 PDT, Max Feil 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Max Feil
Comment 1 2012-06-07 11:46:08 PDT
Created attachment 146343 [details] Patch
Antonio Gomes
Comment 2 2012-06-07 19:57:31 PDT
Comment on attachment 146343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146343&action=review > Source/WebCore/ChangeLog:15 > + I am not providing a test due to the simplicity of this patch > + and the relative difficulty and maintainability issues associated > + with testing how an image is rendered. > + I am not in love with this justification, but it is ok to go without a test for this case :)
WebKit Review Bot
Comment 3 2012-06-07 20:06:40 PDT
Comment on attachment 146343 [details] Patch Clearing flags on attachment: 146343 Committed r119789: <http://trac.webkit.org/changeset/119789>
WebKit Review Bot
Comment 4 2012-06-07 20:06:46 PDT
All reviewed patches have been landed. Closing bug.
Max Feil
Comment 5 2012-11-02 12:43:57 PDT
Closing bug for patch that landed a long time ago.
Note You need to log in before you can comment on or make changes to this bug.