Summary: | [Qt][Win] Add missing includes to fix the build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | hausmann, ossy | ||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||
Version: | 420+ | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 88300 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-06-07 07:22:53 PDT
problematic source files: - Source/WebKit/qt/Api/qwebframe.cpp - Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp - Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp - Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp - Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp MSVC Error log why we need this fix: qwebframe.cpp f:\WebKit\Source\WTF\wtf/PassRefPtr.h(52) : error C2027: use of undefined type ' WebCore::FormState' f:\webkit\source\webcore\loader\PolicyCallback.h(41) : see declaration o f 'WebCore::FormState' f:\WebKit\Source\WTF\wtf/PassRefPtr.h(67) : see reference to function te mplate instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled with [ T=WebCore::FormState ] f:\WebKit\Source\WTF\wtf/PassRefPtr.h(67) : while compiling class templa te member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)' with [ T=WebCore::FormState ] f:\WebKit\Source\WebKit\qt\WebCoreSupport\FrameLoaderClientQt.h(138) : s ee reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled with [ T=WebCore::FormState ] f:\WebKit\Source\WTF\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must Created attachment 146301 [details]
Patch
Including HTMLFormElement.h is enough to make MSVC happy.
Comment on attachment 146301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146301&action=review > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:48 > +#include "HTMLFormElement.h" > #include "HitTestResult.h" It is strange a little bit, but necessarry to make style checker happy. (because HT < Hi) > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:62 > -#include "HistoryItem.h" > +#include "HTMLFormElement.h" > #include "HTMLInputElement.h" > +#include "HistoryItem.h" ditto Comment on attachment 146301 [details] Patch Clearing flags on attachment: 146301 Committed r119970: <http://trac.webkit.org/changeset/119970> All reviewed patches have been landed. Closing bug. |