Bug 88532

Summary: Web Inspector: REGRESSION sorting of object fields is broken in heap profiler
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Alexei Filippov <alph>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, jochen, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexei Filippov
Reported 2012-06-07 06:44:55 PDT
Expand an object in heap profiler and sort e.g. by retained size. The order of object fields does not change.
Attachments
Patch (19.32 KB, patch)
2012-06-07 07:11 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (19.60 KB, patch)
2012-06-07 07:33 PDT, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-06-07 07:11:08 PDT
Created attachment 146283 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-06-07 07:20:03 PDT
Comment on attachment 146283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146283&action=review > LayoutTests/ChangeLog:7 > + A recent change to heap profiler has replaced getters with functions. > + Function calls were missing in couple places after that change. please explain the idea of changes in test framework > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:50 > + setTimeout(step3, 0); please don't use setTimeout in tests. Actually it is a road to flakiness hell. > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:56 > + setTimeout(next, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html:78 > + setTimeout(step3, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:41 > + setTimeout(step3, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:47 > + setTimeout(next, 0); ditto > LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html:72 > + setTimeout(step3, 0); ditto
Alexei Filippov
Comment 3 2012-06-07 07:33:17 PDT
Created attachment 146287 [details] Patch
Ilya Tikhonovsky
Comment 4 2012-06-07 07:34:39 PDT
Comment on attachment 146287 [details] Patch lgtm
Ilya Tikhonovsky
Comment 5 2012-06-07 07:41:42 PDT
Comment on attachment 146287 [details] Patch Clearing flags on attachment: 146287 Committed r119722: <http://trac.webkit.org/changeset/119722>
Ilya Tikhonovsky
Comment 6 2012-06-07 07:41:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.